Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update Web Engine to use Mac-12. #32552

Merged
fluttergithubbot merged 1 commit into from
Apr 12, 2022
Merged

Update Web Engine to use Mac-12. #32552

fluttergithubbot merged 1 commit into from
Apr 12, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 8, 2022

Make Web Engine build to use Mac-12 and Xcode 13.

Bug: flutter/flutter#99885

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Update Web Engine to use Mac-12.
44a2eb0 
Make Web Engine build to use Mac-12 and Xcode 13.

Bug: flutter/flutter#99885
@godofredoc godofredoc requested a review from jmagman April 9, 2022 01:47
jmagman
jmagman approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this is now passing. Mysterious why the simulator issues manifested as Safari failing to launch...

@jmagman
Copy link
Member

jmagman commented Apr 11, 2022

cc @yjbanov @eyebrowsoffire

@godofredoc
Copy link
Contributor Author

godofredoc commented Apr 11, 2022

I'll land it and keep and eye on it to revert as soon as we start identifying issues.

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 11, 2022
@fluttergithubbot fluttergithubbot merged commit aaee5f3 into flutter:main Apr 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2022
@engine-flutter-autoroll
aaee5f3 Update Web Engine to use Mac-12. (flutter/engine#32552)
83b5eea
@jmagman jmagman mentioned this pull request Apr 12, 2022
Closed
godofredoc added a commit that referenced this pull request Apr 12, 2022
@godofredoc
Revert "Update Web Engine to use Mac-12. (#32552)"
3847260 
This reverts commit aaee5f3.
@godofredoc godofredoc mentioned this pull request Apr 12, 2022
Merged
@godofredoc godofredoc deleted the update_engine branch April 19, 2022 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmagman jmagman jmagman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @fluttergithubbot