This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[skia] More SkColorspace include fixes #32532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjlubick
force-pushed
the
more-includes2
branch
from
3f197ed to
1db1a3e
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Apr 11, 2022
Contributor
Author
|
Is the tree in a better spot to let this land? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2022
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Apr 14, 2022
Commit: 61be9229b7f35557fceed203b572dc96384ade42
This was referenced Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 14, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
chri7325
pushed a commit
to Esri/skia
that referenced
this pull request
May 2, 2022
…fo"" This is a reland of commit 00de8cc New client fixes: - http://cl/445903108 Original change's description: > Reland "[includes] Remove SkColorSpace include from SkImageInfo" > > This is a reland of commit 2151fa3 > > New client fixes: > - https://crrev.com/c/3616345 > > Original change's description: > > [includes] Remove SkColorSpace include from SkImageInfo > > > > See also https://skia-review.googlesource.com/c/skia/+/525639 > > > > This should be landed when clients have been fixed. > > - flutter/engine#32532 > > - flutter/engine#32382 > > - http://cl/438808657 > > - http://cl/438803822 > > - http://cl/438807456 > > - http://cl/438808026 > > - http://cl/438821192 > > - https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17542295 > > > > Change-Id: I04beeb2e2b6132c40508c98f4f281981dadbb0d4 > > Bug: skia:13052 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526416 > > Commit-Queue: Kevin Lubick <[email protected]> > > Reviewed-by: Brian Salomon <[email protected]> > > Canary-Chromium-CL: 3616345 > Bug: skia:13052 > Change-Id: I670d3d0d0bab2a86559d9a1184cb36ef008196f3 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/535357 > Reviewed-by: Brian Salomon <[email protected]> Bug: skia:13052 Change-Id: Ibb931dde3f0846609df35d2897989eff0499b7f9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/535896 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Brian Salomon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Skia team is cleaning up our headers. This PR is required to land https://skia-review.googlesource.com/c/skia/+/526416
See issue https://bugs.chromium.org/p/skia/issues/detail?id=13052
This is hopefully the last of the changes needed for SkColorSpace
Pre-launch Checklist
writing and running engine tests.
///).