[web] Migrate Flutter Web to JS static interop - 6. #32514
Conversation
|
@srujzs ptal, this one is a bit more involved because of the replacement of a generative constructor with a factory constructor, but not by much. |
| @staticInterop | ||
| class SkPaint { | ||
| external SkPaint(); | ||
| external factory SkPaint.create(); |
There was a problem hiding this comment.
Any reason we want a named factory? Named and unnamed factories get lowered to the same code anyways here.
There was a problem hiding this comment.
soooo much better, must smaller diff now. ptal.
|
LGTM |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
joshualitt
requested review from
eyebrowsoffire and
yjbanov
and removed request for
yjbanov
|
test-exempt: code refactor with no semantic change |
joshualitt
force-pushed
the
migrate_6
branch
2 times, most recently
from
7a429b0 to
f6e928e
Compare
4 participants
This is CL 6 in a series of CLs to migrate Flutter Web to the new JS static interop API.
This CL migrates more of canvaskit_api.dart(about 40% through that file). I stopped after SkPaint because it was a little more involved.