Build CanvasKit in the Flutter Engine #32510
Conversation
|
/cc @eyebrowsoffire |
harryterkelsen
force-pushed
the
crosscompile-wasm
branch
from
9ea0176 to
5ec414b
Compare
This reverts commit 24e7c0c.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
harryterkelsen
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
DEPS
Outdated
| # which do not build for the web. This toolchain is needed to build CanvasKit | ||
| # for the web engine. | ||
| 'download_emsdk': False, | ||
| 'download_emsdk': True, |
There was a problem hiding this comment.
Do we even need it anymore?
There was a problem hiding this comment.
It could be useful to disable for some builders
There was a problem hiding this comment.
Definitely useful to avoid extra work for builders that don't need it.
I'm curious if this is the right time to default it to true. People working on this can add the varaible to their .gclient file for now to make sure they get it. If we flip this it will increase CI time across the board for engine builds without some recipe changes (unless that's already landed somewhere?).
tools/gn
Outdated
| gn_args['skia_canvaskit_enable_webgl'] = True | ||
| gn_args['skia_canvaskit_enable_webgpu'] = False | ||
| gn_args['skia_canvaskit_profile_build' | ||
| ] = args.runtime_mode == 'profile' or args.runtime_mode == 'debug' |
There was a problem hiding this comment.
nit: some strange formatting on this line
| return gn_args | ||
|
|
||
|
|
||
| def to_gn_wasm_args(args, gn_args): |
There was a problem hiding this comment.
A comment explaining this function could be useful in the future.
* Add `Radius.clamp` and `Radius.clampValues` (#36106) * Build CanvasKit in the Flutter Engine (#32510) * Clamp `RRect` radii when deflating, assert on negative radii (#36062) Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: Harry Terkelsen <[email protected]>
4 participants
Builds CanvasKit in the Flutter engine using the Emscripten toolchain.
Building CanvasKit will allow us to customize and iterate faster.
Fixes flutter/flutter#52588
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.