[fuchsia] Fix --unopt build for Fuchsia. #32502
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
akbiggs
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
akbiggs
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
akbiggs
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
arbreng
left a comment
arbreng
left a comment
There was a problem hiding this comment.
Amazing! thank you so much!
Make sure to remove the note at https://github.com/flutter/flutter/wiki/Compiling-the-engine#compiling-for-fuchsia about how unopt is broken
akbiggs
added
the
waiting for tree to go green
We didn't catch these because the --unopt build was broken for about a year and not well-tested. The --unopt build was recently repaired in #32502.
We didn't catch these because the --unopt build was broken for about a year and not well-tested. The --unopt build was recently repaired in flutter#32502.
6 participants
Several symbols were failing to link in the
--unoptbuild for Fuchsia. I assume this is because those symbols are not being optimized out of the build.To fix this I added several dependencies to some unit tests:
client_wrapper_library_stubs: Used to define stub versions of a few desktop messaging methods, e.g.FlutterDesktopMessengerSend.libdart_jit: Implementations of Dart C++ APIs used by the Dart SDK.dart_io_api: Implementations of IO-related Dart C++ APIs used by the Dart SDK.I also had to add a dependency on
client_wrapper_library_stubsto our runners to make them link in--unopt. That seems weird. I'm doing some additional testing to see if those stubs are actually getting linked into non---unoptbuilds or discarded.