Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux] add missing ATK_STATE_SENSITIVE flag #32487

Merged
robert-ancell merged 2 commits into from
Apr 26, 2022
Merged

[Linux] add missing ATK_STATE_SENSITIVE flag #32487

robert-ancell merged 2 commits into from
Apr 26, 2022

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Apr 7, 2022 •
edited
Loading

This PR sets the ATK_STATE_SENSITIVE flag for enabled widgets to avoid the screen reader reading them out as "greyed".

Fixes: flutter/flutter#101500
See also: https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.33/gtk/a11y/gtkwidgetaccessible.c#L343-344

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jpnurmi
Copy link
Member Author

jpnurmi commented Apr 7, 2022 •
edited
Loading

Before (note: unmute)

sensitive-before.mp4

After (note: unmute)

sensitive-after.mp4

@jpnurmi
Copy link
Member Author

jpnurmi commented Apr 26, 2022

Ping @robert-ancell

cbracken
cbracken approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

robert-ancell
robert-ancell approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell merged commit 46b0889 into flutter:main Apr 26, 2022
@jpnurmi jpnurmi deleted the a11y-greyed branch April 26, 2022 21:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 26, 2022
@engine-flutter-autoroll
46b0889 [Linux] add missing ATK_STATE_SENSITIVE flag (flutter/engine#…
057f8c6 
…32487)
@jpnurmi jpnurmi mentioned this pull request May 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Linux] missing "sensitive" accessibility state

3 participants

@jpnurmi @robert-ancell @cbracken