This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Soft revert of cd7a1e2f14415ab5b1e6d6f45ffe95cdd4c592d6 #32465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
Contributor
Author
|
@cbracken @jonahwilliams FYI since this is disabling stencil buffers on Windows, but again we had no real evidence of how or whether it was helping there. |
chinmaygarde
approved these changes
Apr 6, 2022
dnfield
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively reverts #31967, but keeps a flipped test.
See b/226484927
This created regressions for
customer: money. It did not show any improvements I've been able to see in any benchmarks. Before enabling we need to have a motivating benchmark and should ideally verify that it does not regress internal benchmarks (though that is challenging right now).