This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix deltas when selection is active and composing begins on MacOS #32412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Apr 4, 2022
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
FYI the issue that you linked in the description is wrong.
Renzo-Olivares
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2022
* 9b3117a Create `ImageFilter.dilate`/`ImageFilter.erode` (flutter/engine#32334) * 92a6ade Roll Fuchsia Mac SDK from m_-rjFvCk... to hJaq9O7XI... (flutter/engine#32402) * 31fd1bb Roll Fuchsia Linux SDK from 5abhmXb9Q... to WdxX5Sqix... (flutter/engine#32403) * f088801 Roll Skia from 5215ec1ab9cd to fd9c66e18030 (1 revision) (flutter/engine#32406) * ac21195 Fix inconsistent enum/class private member naming (flutter/engine#32409) * 75e7cfd Fix deltas when selection is active and composing begins on MacOS (flutter/engine#32412) * 7e5989b Fix SemanticsAction naming consistency (flutter/engine#32411) * 1b3e9dc Fix a crash when setting clipboardData to null on iOS (flutter/engine#32413) * ef50b28 Roll Fuchsia Linux SDK from WdxX5Sqix... to PmeDIogNb... (flutter/engine#32422) * b48d65e Roll Fuchsia Mac SDK from hJaq9O7XI... to WBAQhRswX... (flutter/engine#32423)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a selection is active (not collapsed) before starting to compose text, previously we would still send the composing region as the
deltaRange. This was causing the new composed text to be inserted at the caret offset instead of replacing the active selection. This change adds a case to handle this situation, sending the previous composing region as thedeltaRangewhen the selection is collapsed, and sending the selection as thedeltaRangewhen the selection is active.Fixes flutter/flutter#101013
Pre-launch Checklist
writing and running engine tests.
///).