This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Add a way to raster cache the children of a Layer (#32370)" #32378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reland #31875
revert #32370
added commit d685191
In the
RasterizeLayermethod, we must use differentpaint_boundsaccording to differentRasterCacheLayerStrategykLayer, we usepaint_boundsoflayerkLayerChildren, we useorigin_child_paint_boundsofcontainer_layerIssue flutter/flutter#101152 occurs because the
paint_boundsare not correct, resulting in abnormal rendering (when running the test locally I found that the display and animation of the test are not correct). Andworst_frame_rasterizer_time_millisis longer than normal.After fixing this issue,
worst_frame_rasterizer_time_millisof testcolor_filter_and_fade_perf_testwas reduced from140msto105mson my test device (Nexus 6P, Android 8.1.0)cc @flar
fyi @zanderso
Pre-launch Checklist
writing and running engine tests.
///).