Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when frame_damage is empty #32351

Merged
fluttergithubbot merged 14 commits into from
Apr 14, 2022
Merged

Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when frame_damage is empty #32351

fluttergithubbot merged 14 commits into from
Apr 14, 2022

Conversation

@linxuebin1990
Copy link
Member

@linxuebin1990 linxuebin1990 commented Mar 31, 2022

See flutter/flutter#101097

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@linxuebin1990
feat: Skip when frame_damage is empty
0a1b525 
feat: Skip when frame_damage is empty
@linxuebin1990
add kDiscarded status add rasterizer.cc
8110647 
add kDiscarded status add rasterizer.cc
@linxuebin1990
add TRACE_EVENT for ComputeClipRect
a70f4df 
add TRACE_EVENT for ComputeClipRect
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 31, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@linxuebin1990
format the code
f2f1e29 
format the code
@linxuebin1990
format code
8cfc6c4 
format code
@zanderso
Copy link
Member

zanderso commented Mar 31, 2022

From PR review triage: This PR will need tests.

cc @knopp

@zanderso zanderso requested review from flar and iskakaushik April 7, 2022 20:21
@flar
Copy link
Contributor

flar commented Apr 11, 2022

I double checked that we don't end up calling CleanupAfterFrame here which would empty the raster cache, so that shouldn't be an issue.

I don't see any problems, but I would rather @iskakaushik takes a look at this to double-check.

iskakaushik
iskakaushik approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix!

@linxuebin1990
Copy link
Member Author

linxuebin1990 commented Apr 13, 2022

From PR review triage: This PR will need tests.

Hi @zanderso
Thanks for the reply, I have already add the test code, do you have any other suggestions?

@linxuebin1990
Copy link
Member Author

linxuebin1990 commented Apr 13, 2022

I double checked that we don't end up calling CleanupAfterFrame here which would empty the raster cache, so that shouldn't be an issue.

I don't see any problems, but I would rather @iskakaushik takes a look at this to double-check.

Hi @flar
Thanks for the code review! I have already add the test code, do you have any other suggestions?

flar
flar approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo the LGTM from @iskakaushik

flutter-hacker
flutter-hacker reviewed Apr 14, 2022
View reviewed changes
@eggfly eggfly added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Apr 14, 2022
@eggfly eggfly added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 14, 2022
@fluttergithubbot fluttergithubbot merged commit 5b81baa into flutter:main Apr 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
5b81baa Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when fr…
bbcc752 
…ame_damage is empty (flutter/engine#32351)
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@linxuebin1990 @justinmc
Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when frame_dama…
207c5a2 
…ge is empty (flutter#32351)
iskakaushik added a commit to iskakaushik/engine that referenced this pull request May 2, 2022
@iskakaushik
Revert "Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when fr…
528cef4 
…ame_damage is empty (flutter#32351)"

This reverts commit 5b81baa.
@iskakaushik iskakaushik mentioned this pull request May 2, 2022
Merged
iskakaushik added a commit to iskakaushik/engine that referenced this pull request May 2, 2022
@iskakaushik
Revert "Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when fr…
2ee1599 
…ame_damage is empty (flutter#32351)"

This reverts commit 5b81baa.
iskakaushik added a commit that referenced this pull request May 2, 2022
@iskakaushik
Revert "Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when fr…
fb3b3f9 
…ame_damage is empty (#32351)" (#33058)

This reverts commit 5b81baa.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@flutter-hacker flutter-hacker flutter-hacker left review comments

@iskakaushik iskakaushik iskakaushik approved these changes

@flar flar flar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@linxuebin1990 @zanderso @flar @iskakaushik @flutter-hacker @eggfly @fluttergithubbot