This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Generate gen_snapshot_$arch by default #32326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves //flutter/build/archives:create_macos_gen_snapshots target to //flutter/lib/snapshot:create_macos_gen_snapshots and make it part of the :generate_bin_snapshots target in that BUILD.gn file. This makes it part of the default build. When performing a Flutter build using the --local-engine option, the flutter tool looks for the architecture-specific gen_snapshot name, as it does with iOS builds. As such, we should be building the architecture-specific gen_snapshot binary as part of the default build for the given architecture. Issue: flutter/flutter#100804
zanderso
approved these changes
Mar 29, 2022
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 31, 2022
* cb9232b [web] webOnlyWarmupEngine + js-interop APIs (flutter/engine#32017) * 88b7f72 [macOS] Generate gen_snapshot_$arch by default (flutter/engine#32326) * 6dd43e6 Add support for images in display lists. (flutter/engine#32268) * a1106da [web] Make "felt build" wait for both engine and canvaskit builds (flutter/engine#32308)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves //flutter/build/archives:create_macos_gen_snapshots target to
//flutter/lib/snapshot:create_macos_gen_snapshots and makes it part of
the :generate_bin_snapshots target in that BUILD.gn file. This makes it
part of the default build.
When performing a Flutter build using the --local-engine option, the
flutter tool looks for the architecture-specific gen_snapshot name, as
it does with iOS builds. As such, we should be building the
architecture-specific gen_snapshot binary as part of the default build
for the given architecture.
Issue: flutter/flutter#100804
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.