Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

ios text input plugin ignores selection calls when interactive selection is disabled #32223

Merged
chunhtai merged 2 commits into from
Mar 25, 2022
Merged

ios text input plugin ignores selection calls when interactive selection is disabled #32223

chunhtai merged 2 commits into from
Mar 25, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Mar 23, 2022 •
edited by chinmaygarde
Loading

requires flutter/flutter#100649

fixes flutter/flutter#99284

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai mentioned this pull request Mar 23, 2022
Merged
8 tasks
@chunhtai chunhtai requested a review from justinmc March 23, 2022 20:14
@chinmaygarde chinmaygarde changed the title ios text input plugin ignores selection calls when interactive select… ios text input plugin ignores selection calls when interactive selection is disabled Mar 24, 2022
justinmc
justinmc approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm Outdated
withClient:0]);
}

- (void)testIngoresSelectionChangeIfselectionIsDisabled {
Copy link
Contributor

@justinmc justinmc Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "selection" should be capitalized in this name.

@chunhtai chunhtai added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Mar 25, 2022
@chunhtai
Copy link
Contributor Author

chunhtai commented Mar 25, 2022

Needs to wait for flutter/flutter#100649 to be merged first

@chunhtai chunhtai merged commit 6c3cf5f into flutter:main Mar 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2022
@engine-flutter-autoroll
6c3cf5f ios text input plugin ignores selection calls when interactiv…
5747a5f 
…e selection is disabled (flutter/engine#32223)
@yeatse yeatse mentioned this pull request Jul 8, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@justinmc justinmc justinmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting enableInteractiveSelection to false still allows cursor control via a11y on iOS

3 participants

@chunhtai @chinmaygarde @justinmc