This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Dart Plugin Registrant - Reland e97c8016e398 #32189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time (flutter#31418)" (flutter#32162)" This reverts commit ab6b671.
gaaclarke
force-pushed
the
reland-e97c8016e398d91d414d298ae9ca87e735441476
branch
from
ac12d06 to
79e7a37
Compare
8 tasks
gaaclarke
force-pushed
the
reland-e97c8016e398d91d414d298ae9ca87e735441476
branch
6 times, most recently
from
a6b3550 to
3728a60
Compare
…ead of looking for it.
gaaclarke
force-pushed
the
reland-e97c8016e398d91d414d298ae9ca87e735441476
branch
from
3728a60 to
5d9cf53
Compare
gaaclarke
changed the title
gaaclarke
changed the title
blasten
reviewed
Mar 24, 2022
runtime/dart_plugin_registrant.cc
Outdated
| // TODO(gaaclarke): Find a way to remove this branch so the field is | ||
| // required. I couldn't get it working with unit tests. | ||
| return InvokeDartPluginRegistrantIfAvailable(library); | ||
| } else { |
blasten
reviewed
Mar 24, 2022
runtime/dart_plugin_registrant.cc
Outdated
| if (registrant_file_uri_string.empty()) { | ||
| FML_LOG(ERROR) << "Unexpected empty dartPluginRegistrantLibrary."; | ||
| return false; | ||
| } else { |
blasten
approved these changes
Mar 24, 2022
gaaclarke
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2022
GaryQian
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2022
* e8d1145 Roll Skia from 7ef299accba6 to a7c2d73690d3 (1 revision) (flutter/engine#32222) * c6e36bb Roll Dart SDK from b5d0b8fd4fad to 8d8944d40cd8 (1 revision) (flutter/engine#32224) * a16fa3f Roll Fuchsia Linux SDK from sMai0ocli... to oTjwOwAoJ... (flutter/engine#32225) * b455909 Roll Skia from a7c2d73690d3 to faf520c0009b (7 revisions) (flutter/engine#32228) * 25cbaf2 Dart Plugin Registrant - Reland e97c801 (flutter/engine#32189) * 2b90585 Roll Fuchsia Mac SDK from daGNAjLwt... to 4MoGGSDPk... (flutter/engine#32229) * 5d2aeca Roll Skia from faf520c0009b to 9aa9c14ffdae (1 revision) (flutter/engine#32230)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original commit is in this PR. The difference is in the second commit and instead of hunting for the dart plugin registrant we look for it referenced at a particular place.
Framework PR: flutter/flutter#100572
Relands: #31418
The revert: #32162
Integration test in framework PR.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.