This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable MSAA behind a flag for Android GL, add TODOs for other platforms #32128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
| /// Setting this value to 0 or 1 disables MSAA. | ||
| /// If it is not 0 or 1, it must be one of 2, 4, 8, or 16. However, if the | ||
| /// GPU does not support the requested sampling value, MSAA will be disabled. | ||
| uint8_t msaa_samples = 0; |
Contributor
There was a problem hiding this comment.
I think this is fine, assuming that we will eventually either remove it entirely or settle on a fixed sample count?
Contributor
Author
There was a problem hiding this comment.
Idea is to leave it disabled for now, yes.
Contributor
Author
There was a problem hiding this comment.
I'd like to easily be able to swtich between 2x and 4x sampling for testing purposes on various devices
Contributor
Author
|
@blasten @jason-simmons @zanderso fyi. This change is intended to have no effect unless opted into. There is no intent to expose this flag via the tool just yet. It should make it easier to experiment with different AA strategies though. |
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables MSAA behind a flag for Android GL backend.
Part of flutter/flutter#100392
Takes a sample count as an argument, if greater than 1 try to enable MSAA at that level, ignores invalid values.
Tests for C++ settings, Android Settings, Android GL Context.