This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Switch the renderer to impeller based on the presence of a command line flag. #31959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
Member
|
Looks like two differently configured Dart VMs are included in the link somehow. |
Member
Author
I'm submitting an Impeller patch to fix those. Think those were caused by flutter/impeller@3310f85 |
dnfield
approved these changes
Mar 10, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM as long as CI is happy
chinmaygarde
force-pushed
the
impeller_switch
branch
from
d00ef7f to
0fb86bc
Compare
Contributor
|
Looks like licenses are still off and clang doesn't like using std::abs in a constexpr |
This was referenced Mar 14, 2022
chinmaygarde
force-pushed
the
impeller_switch
branch
from
8eaa99c to
561be79
Compare
bdero
approved these changes
Mar 14, 2022
This was referenced Mar 14, 2022
chinmaygarde
force-pushed
the
impeller_switch
branch
from
fa7da14 to
6095e7e
Compare
chinmaygarde
force-pushed
the
impeller_switch
branch
from
6095e7e to
307859e
Compare
Member
Author
|
I've removed any dependencies on Impeller from //flow and it ought to be sufficient for the internal build rules to avoid pulling in Impeller and compiling the Impeller specific TUs in shell/platform and shell/gpu. I've also fixed all remaining issues and filed bugs as necessary and this round of presubs is expected to pass. Landing now. |
chinmaygarde
force-pushed
the
impeller_switch
branch
from
307859e to
bc09ae9
Compare
chinmaygarde
added
the
waiting for tree to go green
…ne flag. Specifying the `--enable-impeller` flag will switch the renderer to using Impeller instead of Skia. On platforms where Impeller is not supported, this flag is ignored. The notion of the `flutter::SurfaceFrame` has been augmented. Now, in the absence of a Skia surface to render to, the surface frame will render into a display list instead. Impeller variants of the context and surface variants have been added to `shell/gpu` and `shell/platform`. The variants prepare surface frames that don’t/can’t specify a Skia surface thus forcing the surface frame to render to a display list instead. Then, in the submit callback, they forward the display list ops to the Impeller display list dispatcher. This scheme has been chosen as it requires the fewest updates to engine internals which all depend on Skia data structures. Instead of updating all call-sites to be Skia neutral, the display list interface itself is being made graphics package agnostic.
chinmaygarde
force-pushed
the
impeller_switch
branch
from
bc09ae9 to
b32e71d
Compare
zanderso
approved these changes
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 16, 2022
* 0199e90 [macOS] fix text selection when there's composing text (flutter/engine#31936) * 0ca0ce1 Roll Skia from 9565f4bd902b to a48a3c9417c0 (3 revisions) (flutter/engine#32044) * a60e8c3 Switch the renderer to impeller based on the presence of a command line flag. (flutter/engine#31959) * 24051b6 Roll Fuchsia Mac SDK from EOVjR8JSN... to jvlI1s78T... (flutter/engine#32047) * fef6232 Roll Skia from a48a3c9417c0 to ffb49630eb1a (3 revisions) (flutter/engine#32048) * 5a80834 [ci.yaml] Migrate remaining targets to cocoon scheduler (flutter/engine#32018) * cd7a1e2 Support stencil buffers on OpenGL for Windows and Android (flutter/engine#31967) * dc22c4c Add DlColorSource objects to hold information for SkShaders (flutter/engine#31981)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the
--enable-impellerflag will switch the renderer to usingImpeller instead of Skia. On platforms where Impeller is not supported, this
flag is ignored.
The notion of the
flutter::SurfaceFramehas been augmented. Now, in theabsence of a Skia surface to render to, the surface frame will render into a
display list instead.
Impeller variants of the context and surface variants have been added to
shell/gpuandshell/platform. The variants prepare surface frames thatdon’t/can’t specify a Skia surface thus forcing the surface frame to render to a
display list instead. Then, in the submit callback, they forward the display
list ops to the Impeller display list dispatcher.
This scheme has been chosen as it requires the fewest updates to engine
internals which all depend on Skia data structures. Instead of updating all
call-sites to be Skia neutral, the display list interface itself is being made
graphics package agnostic.