This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] fix text selection when there's composing text #31936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM but looks like there's a licence check failure unrelated to your PR that somehow got merged: |
Member
|
@cbracken That was a transient failure in the tree that since been fixed. @LongCatIsLooong Please rebase the PR on ToT for the presubs to get rolling again. Thanks. |
LongCatIsLooong
force-pushed
the
fix-composing-selection
branch
from
615c457 to
f8fef39
Compare
Contributor
Author
|
@cbracken I updated the pull request a bit to fix the problem where |
LongCatIsLooong
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 16, 2022
* 0199e90 [macOS] fix text selection when there's composing text (flutter/engine#31936) * 0ca0ce1 Roll Skia from 9565f4bd902b to a48a3c9417c0 (3 revisions) (flutter/engine#32044) * a60e8c3 Switch the renderer to impeller based on the presence of a command line flag. (flutter/engine#31959) * 24051b6 Roll Fuchsia Mac SDK from EOVjR8JSN... to jvlI1s78T... (flutter/engine#32047) * fef6232 Roll Skia from a48a3c9417c0 to ffb49630eb1a (3 revisions) (flutter/engine#32048) * 5a80834 [ci.yaml] Migrate remaining targets to cocoon scheduler (flutter/engine#32018) * cd7a1e2 Support stencil buffers on OpenGL for Windows and Android (flutter/engine#31967) * dc22c4c Add DlColorSource objects to hold information for SkShaders (flutter/engine#31981)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.