[ui] replace dynamic with Object? #31771
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| runZonedGuarded<void>(() { | ||
| if (userMainFunction is _ListStringArgFunction) { | ||
| (userMainFunction as dynamic)(args); | ||
| userMainFunction(args); |
There was a problem hiding this comment.
no cast necessary
| final List<dynamic> objects = _ensureObjectsInitialized(); | ||
| if (objects[_kImageFilterIndex]?.creator != value) { | ||
| final List<Object?> objects = _ensureObjectsInitialized(); | ||
| final _ImageFilter? imageFilter = objects[_kImageFilterIndex] as _ImageFilter?; |
There was a problem hiding this comment.
This was a dynamic call before
|
|
||
| final double textScaleFactor = (data['textScaleFactor'] as num).toDouble(); | ||
| final bool alwaysUse24HourFormat = data['alwaysUse24HourFormat'] as bool; | ||
| final double textScaleFactor = (data['textScaleFactor']! as num).toDouble(); |
There was a problem hiding this comment.
These were implicit null checks before
|
test-exempt: code refactor with no semantic change |
jonahwilliams
added
the
waiting for tree to go green
4 participants
In most places
dynamiccan be swapped out withObject?. This allowed removing a few casts by restructuring some of the code