Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix web_engine_archive target. #31751

Merged
fluttergithubbot merged 3 commits into from
Mar 2, 2022
Merged

Fix web_engine_archive target. #31751

fluttergithubbot merged 3 commits into from
Mar 2, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 2, 2022

The target to archive web_engine fails on windows and we didn't catch it
on presubmit because we are not yet running those targets.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Fix web_engine_archive target.
e98e6c3 
The target to archive web_engine fails on windows and we didn't catch it
on presubmit because we are not yet running those targets.

Bug: flutter/flutter#81855
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 2, 2022
@godofredoc
Copy link
Contributor Author

godofredoc commented Mar 2, 2022

@godofredoc godofredoc requested review from aam, dnfield and zanderso March 2, 2022 05:24
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 2, 2022
@fluttergithubbot fluttergithubbot merged commit 988e8fc into flutter:main Mar 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
988e8fc Fix web_engine_archive target. (flutter/engine#31751)
a6c381c
@godofredoc godofredoc deleted the fix_web_engine branch January 12, 2024 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

@zanderso zanderso Awaiting requested review from zanderso

2 more reviewers

@cbracken cbracken cbracken approved these changes

@aam aam aam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @cbracken @aam @fluttergithubbot