This repository was archived by the owner on Feb 25, 2025. It is now read-only.
detect cases when Skia nops filters by returning nullptr to prevent crashes #31689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Feb 26, 2022
|
|
||
| import 'package:litetest/litetest.dart'; | ||
|
|
||
| const Color transparent = Color(0x00000000); |
Contributor
There was a problem hiding this comment.
Ubernit: transparentBlack
Contributor
Author
There was a problem hiding this comment.
If there's a test failure I have to amend it for...
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered some crashes downstream when Flutter apps create ColorFilter objects that are essentially a NOP operation. Internally in the new DlColorFilter code we missed cases where the
skia_object()version of the filter might return null. This PR fixes a couple of situations with respect to these NOP filters: