Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Feb 25, 2022

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers CaseyHillers changed the base branch from main to flutter-2.12-candidate.0 February 25, 2022 19:49
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@CaseyHillers CaseyHillers force-pushed the flutter-2.12-candidate.0 branch from 4077039 to 8d2f127 Compare February 25, 2022 21:37
@CaseyHillers CaseyHillers changed the title Empty commit to trigger recipe fix [Cherrypick] Generate fonts in the expected location #31575 Feb 25, 2022
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 25, 2022
* Generate fonts in the expected location.

Fonts-subset is generated directly in out/../zip_archives but the final
destination is expected to be inside a folder like linux-x64. This PR
generates the file directly in the expected path.

Bug: flutter/flutter#81855

* Fix font zip tests.

* Revert changes to run_tests.py

* Update host_os_cpu_name variable to report darwin for mac.

* Fix variable names.

* Calculate prebuilts path using mac instead of darwin.

* Add platform to fontset path.

* Fix platforms map.

* Add debugging.

* Add win32 to the map of artifact locations.

* Use full_platform_name instead of host_os_name.

* Use x32 for windows font binaries.

* Fix paths for debug version in windows.

* Use x64 for win32.

* Remove additional logging.

* Add linux2 to map of platforms.
@CaseyHillers CaseyHillers force-pushed the flutter-2.12-candidate.0 branch from 8d2f127 to 0fa2fd1 Compare February 25, 2022 21:51
@CaseyHillers CaseyHillers changed the title [Cherrypick] Generate fonts in the expected location #31575 [Cherrypick] Changes related to Build+Test separation Feb 25, 2022
@CaseyHillers CaseyHillers merged commit 373b5e3 into flutter:flutter-2.12-candidate.0 Feb 25, 2022
@CaseyHillers CaseyHillers deleted the flutter-2.12-candidate.0 branch February 25, 2022 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants