Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

This is the full refactoring of the linux host engine build relying
entirely on artifacts generated by gn and ninja and using the engine v2
recipes.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Copy link
Contributor Author

godofredoc commented Feb 24, 2022

\cc @whesse

@godofredoc
Copy link
Contributor Author

\cc @athomas

@godofredoc
Copy link
Contributor Author

This new build will initially run only on staging.

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on ci.yaml side

@godofredoc godofredoc requested a review from zanderso February 24, 2022 22:59
This is the full refactoring of the linux host engine build relying
entirely on artifacts generated by gn and ninja and using the engine v2
recipes.

Bug: flutter/flutter#81855
@godofredoc
Copy link
Contributor Author

@dnfield @zanderso any concerns with landing this change? It will only impact staging.

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2022
@fluttergithubbot fluttergithubbot merged commit 96200db into flutter:main Mar 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2022
@godofredoc godofredoc deleted the linux_host_builder_configs branch January 12, 2024 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants