This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix includes of Skia types #31654
Merged
Fix includes of Skia types #31654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Feb 24, 2022
jason-simmons
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
flar
approved these changes
Feb 24, 2022
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2022
pull bot
pushed a commit
to TheRakeshPurohit/skia
that referenced
this pull request
Mar 7, 2022
…t.h" This is a reland of 37b8239 Upstack changes: - http://ag/17004908 - flutter/engine#31654 Original change's description: > [includes] Remove include link between SkPathRef.h and SkRRect.h > > According to go/chrome-includes [1], this will save about > 40MB (0.02%) off the Chrome build. http://screen/4GnPjFaYpwCVHVL > > I'm not quite sure why the link is so expensive, but we can > forward declare it and move the implementation from the .h > to the .cpp file easily enough. > > [1] https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html#view=edges&filter=%5Ethird_party%2Fskia%2Finclude%2Fprivate%2FSkPathRef%5C.h%24&sort=includes&reverse=&includer=%5Ethird_party%2Fskia%2Finclude%2Fprivate%2FSkPathRef%5C.h%24&included=&limit=1000 > > Canary-Chromium-CL: 3485346 > Change-Id: Ie3a5e7a735426f883a6c06ddbd3b8bf148bf1709 > Bug: 242216 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512158 > Reviewed-by: Robert Phillips <[email protected]> Bug: 242216 Change-Id: I31288895528251fd59913427b95b9f88a871d14b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/512776 Reviewed-by: Robert Phillips <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to land (or reland) these 3 CLs in Skia that tidy up how we include things. This is part of an effort to reduce compile time by reducing header/include bloat (https://crbug.com/242216).
I tested this locally by patching in the three above CLs into third_party/skia and compiling on Linux. Our autoroller and Canary jobs will verify the fix before landing into Skia and rolling into flutter-engine.
Pre-launch Checklist
writing and running engine tests.
///).