Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

This is for an internal release. Tracking bug: b/220976275

* Turn off mark_when_idle option as it appears to cause a regression.
We can turn it back on once we investigate the cause and fix it.

* Format.
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 24, 2022
@CaseyHillers
Copy link
Contributor Author

@godofredoc can you merge this? I lack permissions, and the autosubmit bot doesn't seem to work on the release branches

@godofredoc godofredoc merged commit b7078f3 into flutter:flutter-2.12-candidate.0 Feb 24, 2022
@CaseyHillers CaseyHillers deleted the flutter-2.12-candidate.0 branch February 24, 2022 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants