This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Generate fonts in the expected location. #31575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fonts-subset is generated directly in out/../zip_archives but the final destination is expected to be inside a folder like linux-x64. This PR generates the file directly in the expected path. Bug: flutter/flutter#81855
godofredoc
requested review from
dnfield and
zanderso
and removed request for
zanderso
Contributor
Author
|
Landing this will require breaking the tree for a few mins as we'll need to land it along with a recipes change. |
dnfield
approved these changes
Feb 23, 2022
Contributor
Author
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Feb 25, 2022
* Generate fonts in the expected location. Fonts-subset is generated directly in out/../zip_archives but the final destination is expected to be inside a folder like linux-x64. This PR generates the file directly in the expected path. Bug: flutter/flutter#81855 * Fix font zip tests. * Revert changes to run_tests.py * Update host_os_cpu_name variable to report darwin for mac. * Fix variable names. * Calculate prebuilts path using mac instead of darwin. * Add platform to fontset path. * Fix platforms map. * Add debugging. * Add win32 to the map of artifact locations. * Use full_platform_name instead of host_os_name. * Use x32 for windows font binaries. * Fix paths for debug version in windows. * Use x64 for win32. * Remove additional logging. * Add linux2 to map of platforms.
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Feb 25, 2022
* Generate fonts in the expected location. Fonts-subset is generated directly in out/../zip_archives but the final destination is expected to be inside a folder like linux-x64. This PR generates the file directly in the expected path. Bug: flutter/flutter#81855 * Fix font zip tests. * Revert changes to run_tests.py * Update host_os_cpu_name variable to report darwin for mac. * Fix variable names. * Calculate prebuilts path using mac instead of darwin. * Add platform to fontset path. * Fix platforms map. * Add debugging. * Add win32 to the map of artifact locations. * Use full_platform_name instead of host_os_name. * Use x32 for windows font binaries. * Fix paths for debug version in windows. * Use x64 for win32. * Remove additional logging. * Add linux2 to map of platforms.
CaseyHillers
pushed a commit
that referenced
this pull request
Feb 25, 2022
* GN targets to create flutter_web_sdk. (#31556) * Fix gn problem impacting fuchsia builds. (#31615) * Generate fonts in the expected location. (#31575) * Generate fonts in the expected location. Fonts-subset is generated directly in out/../zip_archives but the final destination is expected to be inside a folder like linux-x64. This PR generates the file directly in the expected path. Bug: flutter/flutter#81855 * Fix font zip tests. * Revert changes to run_tests.py * Update host_os_cpu_name variable to report darwin for mac. * Fix variable names. * Calculate prebuilts path using mac instead of darwin. * Add platform to fontset path. * Fix platforms map. * Add debugging. * Add win32 to the map of artifact locations. * Use full_platform_name instead of host_os_name. * Use x32 for windows font binaries. * Fix paths for debug version in windows. * Use x64 for win32. * Remove additional logging. * Add linux2 to map of platforms. Co-authored-by: godofredoc <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2022
zanderso
reviewed
Feb 28, 2022
|
|
||
| zip_bundle("font-subset") { | ||
| output = "font-subset.zip" | ||
| output = "${full_platform_name}/font-subset.zip" |
Member
There was a problem hiding this comment.
I think this could have been done with a soft transition without breaking the tree by having two copies of this rule, one with the old output and one with the new output?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fonts-subset is generated directly in out/../zip_archives but the final
destination is expected to be inside a folder like linux-x64. This PR
generates the file directly in the expected path.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.