Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Feb 18, 2022

Buildroot PR: flutter/buildroot#549

Wired this up against my in-progress imgui backend for impeller.

@bdero
Copy link
Member Author

bdero commented Feb 22, 2022

Here's how I sorted out the licenses:

  • imgui.cpp has a license mention that was getting detected as a full license, so I added a unique signature to the license mentions list, which seems to be for this purpose.
  • There's a generated opengl loader in the examples (generated by this) which contains the Unlicense statement and no copyright claim, so I added this text to the "csNoCopyrights" list.
  • The examples contain a copy of the Synergy micro client, which contain zlib copyright headers. The text wraps differently than the other zlib variations, so I appended it a new variation below the others.

@chinmaygarde
Copy link
Member

The dependency is test-only. This may be ignored by the script.

@bdero
Copy link
Member Author

bdero commented Feb 22, 2022

Ah I totally missed that. Well at least I know how the license script works now. :)

@bdero
Copy link
Member Author

bdero commented Feb 22, 2022

Alrighty, I excluded imgui from the license script.

@bdero bdero added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Feb 23, 2022
@fluttergithubbot fluttergithubbot merged commit 91283e4 into flutter:main Feb 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants