This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert mark idle #31487
Merged
Revert mark idle #31487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can turn it back on once we investigate the cause and fix it.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
xster
approved these changes
Feb 16, 2022
rmacnak-google
approved these changes
Feb 16, 2022
zanderso
approved these changes
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Feb 24, 2022
* Turn off mark_when_idle option as it appears to cause a regression. We can turn it back on once we investigate the cause and fix it. * Format.
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Feb 24, 2022
* Turn off mark_when_idle option as it appears to cause a regression. We can turn it back on once we investigate the cause and fix it. * Format.
godofredoc
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Turn off mark_when_idle option as it appears to cause a regression. We can turn it back on once we investigate the cause and fix it. * Format. Co-authored-by: Siva <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option mark_when_idle appears to cause a regression on some benchmarks, reverting it for now until we root cause the regression and fix it.