This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Expose picture.debugDisposed, make sure we do not crash when working with disposed pictures #31453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with disposed pictures
flutter-dashboard
bot
added
the
platform-web
dnfield
commented
Feb 14, 2022
Comment on lines
+26
to
+33
| if (assertsEnabled) { | ||
| expect( | ||
| () => builder.addPicture(Offset.zero, picture), | ||
| throwsA(isInstanceOf<AssertionError>()), | ||
| ); | ||
| } else { | ||
| builder.addPicture(Offset.zero, picture); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Without the changes in scene_builder.cc, this code will cause a segfault.
Contributor
Author
|
@godofredoc looks like the recipe or ciyaml is out of whack here? |
Contributor
Author
|
I thought I had merged to head and hadn't I guess. That's likely the problem. |
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2022
…working with disposed pictures (flutter/engine#31453)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#85471
Fixes flutter/flutter#98434
xref b/217635834