SPIR-V Transpiler Control Flow #31451
Conversation
No tests are modified because this commit does not make a change to the API or behavior of the API. This change prepares the transpiler for the addition of control flow by adding an additonal layer of indirection between processing instructions from the SPIR-V byte code and writing the shader source string. The changes are the following: - Functions are written to _Function objects - Blocks are written to _Block objects - Instructions per block are collected into _Instruction objects - Instructions are written lazily when functions are written, allowing late-resolution of variable names, inlining of expressions that are only used once, and indenting at write time.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
- factor operators into enum / map of strings - const Set containing compound-assignment operators - detect compound assignment inside opStore - reformat exceptions - add _CompoundAssignment class - a few other smaller changes
lib/spirv/lib/src/instructions.dart
Outdated
|
|
||
| _Transpiler get transpiler => function.transpiler; | ||
|
|
||
| void writeContinue(_BlockContext ctx) { |
There was a problem hiding this comment.
Does this need to be public? Same question for other methods in this class.
There was a problem hiding this comment.
Changed methods to be private - however none of the methods in any of the classes need to be public since all of the classes are private to the library other than TranspileResult. Everything public is defined in lib/spirv.dart. I think it may make sense to file a new issue for refactoring the other members in _function/_transpiler/ etc.
chriscraws
added
the
waiting for tree to go green
3 participants
This PR adds support for
if,elseandforcontrol flow operators.This does not add support for
while, because SkSL only supportsforloops with very specific requirements - a lot of the code in this PR deals with validating and transforming the SPIR-V to generate valid SkSL.flutter/flutter#85261
flutter/flutter#93800
Pre-launch Checklist
writing and running engine tests.
///).