This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable a11y unittests on Windows #31387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw280
approved these changes
Feb 11, 2022
This enables accessibility unittests on Windows as part of our CI testing. It also corrects two unit tests which were fixed by #29773, which fixed flutter/flutter#78460. Finally it disables an AXFragmentRoot test that times out. We don't use AXFragmentRoot in Flutter as it's only used with UI Automation APIs, which Flutter does not use (we use MSAA). Issue: flutter/flutter#98225
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables accessibility unittests on Windows as part of our CI testing.
It also corrects two unit tests which were fixed by #29773, which fixed flutter/flutter#78460.
Issue: flutter/flutter#98225
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.