This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Win32, Keyboard] Check the states of all modifiers #31297
Merged
fluttergithubbot
merged 21 commits into
flutter:main
from
dkwingsmt:win-key-all-modifiers-check
Feb 16, 2022
Merged
[Win32, Keyboard] Check the states of all modifiers #31297
fluttergithubbot
merged 21 commits into
flutter:main
from
dkwingsmt:win-key-all-modifiers-check
Feb 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix embedder test Implement and finish tests
0c82961 to
0a5dcaa
Compare
gspencergoog
approved these changes
Feb 15, 2022
Contributor
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects: text input
platform-windows
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR fixes flutter/flutter#76736 by making all 8 (previously 4) modifier keys as critical keys. Critical keys are keys that Flutter checks true state of upon every event and synthesizes events for to make up desynchronized states.
This PR adds a new type of
KeyboardChangecalledExpectForgedMessage, which not only checks an upcoming forged event (such as the ControlLeft up forged by an AltGr up), and also holds succeedingKeyStateChangeuntil the forged event occurs. This is necessary to correctly test the AltGr behaviors.This PR also allows mocking all kinds of
MapVirtualKeyinstead of justVK_TO_CHAR, although it turns out it's not used in tests.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.