Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Feb 7, 2022

This PR fixes flutter/flutter#76736 by making all 8 (previously 4) modifier keys as critical keys. Critical keys are keys that Flutter checks true state of upon every event and synthesizes events for to make up desynchronized states.

This PR adds a new type of KeyboardChange called ExpectForgedMessage, which not only checks an upcoming forged event (such as the ControlLeft up forged by an AltGr up), and also holds succeeding KeyStateChange until the forged event occurs. This is necessary to correctly test the AltGr behaviors.

This PR also allows mocking all kinds of MapVirtualKey instead of just VK_TO_CHAR, although it turns out it's not used in tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt force-pushed the win-key-all-modifiers-check branch from 0c82961 to 0a5dcaa Compare February 7, 2022 23:57
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 15, 2022
@fluttergithubbot fluttergithubbot merged commit 4ea2394 into flutter:main Feb 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2022
@dkwingsmt dkwingsmt deleted the win-key-all-modifiers-check branch February 16, 2022 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: text input platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion: Potentially add more critical keys to the Windows keyboard system

3 participants