-
Notifications
You must be signed in to change notification settings - Fork 6k
Make sure 'FlutterSplashView.onRestoreInstanceState' doesn't crash #31045
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sane to me, but needs a test.
Done |
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
How fix this issue on old version like flutter 1.22.4 |
|
Which version is in effect? |
|
I got the same crash after using FlutterFragment on flutter sdk2.10.3,product mode. Fatal Exception: java.lang.ClassCastException |
fix flutter/flutter#94329
This crash also happened in my app, I think
FlutterSplashViewneeds to add protection code here, just likeTextViewhttps://android.googlesource.com/platform/frameworks/base/+/jb-mr0-release/core/java/android/widget/TextView.java#3270
Pre-launch Checklist
writing and running engine tests.
///).