This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] do not allocate canvases just for text #30804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
This comment was marked as outdated.
This comment was marked as outdated.
yjbanov
force-pushed
the
no-canvas-for-text
branch
2 times, most recently
from
709bbe8 to
661e209
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ditman
force-pushed
the
no-canvas-for-text
branch
from
661e209 to
23e3f7d
Compare
8 tasks
|
Gold has detected about 7 new digest(s) on patchset 1. |
|
Golden file changes are available for triage from new commit, Click here to view. |
ditman
added
the
waiting for tree to go green
ditman
approved these changes
Apr 18, 2022
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Reviewed goldens too. Most of them were related to text anti-aliasing (as usual) and shadow rendering. One of the golden tests for span backgrounds showed a small artifact (only with large fonts), seemed like a browser rounding error:
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Apr 22, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
Apr 22, 2022
…es (#32867) * [web] do not allocate canvases just for text (#30804) * [web:a11y] fix traversal and hit-test orders (#32712) * [web:a11y] implement traversal and hit-test orders * remove unused intersectionIndicesNew * canvaskit: fix platform view offset and scene host initialization * remove "we" in a bunch of comments Co-authored-by: Yegor <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only paint text into canvas if there is already a canvas. Do not create a canvas just for text.
This PR includes some clean-ups:
CanvasPool.isEmpty/isNotEmptywithhasCanvas(the pool can be full of canvases and still returntruefromisEmpty, which is surprising).drawOnCanvastocanDrawOnCanvas.Fixes flutter/flutter#96498