Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use the correct Settings in Engine::Spawn #30741

Merged
gaaclarke merged 2 commits into from
Jan 12, 2022
Merged

Use the correct Settings in Engine::Spawn #30741

gaaclarke merged 2 commits into from
Jan 12, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jan 7, 2022 •
edited
Loading

I guess when creating RuntimeController, we should use settings in Engine::Spawn parameter instead of settings_ of spawner.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 7, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@eggfly eggfly self-requested a review January 12, 2022 03:44
@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented Jan 12, 2022

(Add the unit test and remove the "need tests" label)

gaaclarke
gaaclarke approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@gaaclarke gaaclarke merged commit fba23ea into flutter:main Jan 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2022
@engine-flutter-autoroll
fba23ea Use the correct Settings in Engine::Spawn (flutter/engine#30741)
1bf83ba
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@ColdPaleLight @JsouLiang
Use the correct Settings in Engine::Spawn (flutter#30741)
57b2f38 
* Use the correct Settings in Engine::Spawn

* Add unit tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eggfly eggfly eggfly approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ColdPaleLight @eggfly @gaaclarke