Call IAccessible::accFocus to move a11y focus #30256

cbracken · 2021-12-09T22:44:11Z

On receipt of a FOCUS_CHANGED event from the AX tree, call
IAccessible::accFocus to tell screen readers to move the accessibility
focus to that node. This is in addition to setting the keyboard focus
via the EVENT_OBJECT_FOCUS event.

Issue: flutter/flutter#77838

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

On receipt of a FOCUS_CHANGED event from the AX tree, call IAccessible::accFocus to tell screen readers to move the accessibility focus to that node. This is in addition to setting the keyboard focus via the EVENT_OBJECT_FOCUS event. Issue: flutter/flutter#77838

chunhtai · 2021-12-09T22:48:00Z

shell/platform/windows/accessibility_bridge_delegate_win32.cc

      break;
    case ui::AXEventGenerator::Event::FOCUS_CHANGED:
      DispatchWinAccessibilityEvent(win_delegate, EVENT_OBJECT_FOCUS);
+      SetFocus(win_delegate);


why not just win_delegate->SetFocus()

Purely so I can capture the call in the test :(

chunhtai · 2021-12-09T22:49:15Z

shell/platform/windows/accessibility_bridge_delegate_win32.cc

      DispatchWinAccessibilityEvent(win_delegate, EVENT_OBJECT_REORDER);
      break;
    case ui::AXEventGenerator::Event::FOCUS_CHANGED:
      DispatchWinAccessibilityEvent(win_delegate, EVENT_OBJECT_FOCUS);


does this line do anything?

Sets the HWND focus.

chunhtai

LGTM

…#30256)

* 37223ca [fuchsia] Use network-legacy-deprecated pkg in embedder test (flutter/engine#30244) * 86769ee Roll Dart SDK from 2ace65b1b408 to 2091ff49c513 (8 revisions) (flutter/engine#30251) * 5312e55 Win32: Handle OnAccessibilityEvent (flutter/engine#30176) * 8fd8912 Revert the latest rolls of the Fuchsia SDK (flutter/engine#30254) * df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine#30256) * 6aa8d5c Simplify win32 platform node delegate GetParent (flutter/engine#30258) * ff328f0 Fix TestAccessibilityBridgeDelegate event caching (flutter/engine#30260) * 842281e Test shell/platform/common a11y code on Windows (flutter/engine#30262) * 806d8bc Roll Dart SDK from 2091ff49c513 to 7b6056f9db7f (1 revision) (flutter/engine#30259) * 1ed10bb Android accessibility bridge also fire selection change event when it predict selection change. (flutter/engine#30199) * 71fdb89 Override FlutterPlatformNodeDelegate::GetUniqueId (flutter/engine#30261) * 5aa7b30 Cleanup old ndk CIPD upload script (flutter/engine#30253) * 3653881 Roll Fuchsia Mac SDK from EcjcLVqar... to 1DgBWWOWV... (flutter/engine#30265) * f764864 Roll Skia from 44c81d149273 to a964a72174e8 (9 revisions) (flutter/engine#30255) * 2eca05e Migrate to Mockito 4.1.0 (flutter/engine#30257) * 1a6005f Add iOS version to scenario golden images (flutter/engine#30263) * 59c6f28 Roll Fuchsia Linux SDK from 3rLypXNTd... to UPWdoQziF... (flutter/engine#30266) * 5502a0a Fix eglPresentationTimeANDROID is no effective (flutter/engine#30182) * bb20dd0 Roll Skia from a964a72174e8 to 4d35c0d31d79 (16 revisions) (flutter/engine#30269) * 33f4c32 Revert "Accessibility number formatting improvements for Windows (#29773)" (flutter/engine#30267) * 5ece42f Roll Dart SDK from 7b6056f9db7f to f568598a262e (4 revisions) (flutter/engine#30270) * 8d1272b Roll Dart SDK from f568598a262e to 49d5a2f58c4a (3 revisions) (flutter/engine#30277) * 8b074c8 Roll Fuchsia Mac SDK from 1DgBWWOWV... to GoQ7KEnqp... (flutter/engine#30278) * e1a71cf Roll Fuchsia Linux SDK from UPWdoQziF... to hhFGKobVD... (flutter/engine#30279) * 6dc4046 Roll Fuchsia Mac SDK from GoQ7KEnqp... to Y_9lCzY64... (flutter/engine#30280) * ff7d4d6 Roll Fuchsia Linux SDK from hhFGKobVD... to NAkkk-Vn5... (flutter/engine#30281) * 2f97ac4 Roll Dart SDK from 49d5a2f58c4a to 01a9d4e9ede7 (1 revision) (flutter/engine#30283) * 85f4d68 Roll Fuchsia Linux SDK from NAkkk-Vn5... to V2JLZw4H1... (flutter/engine#30285) * 5130b83 Roll Fuchsia Mac SDK from Y_9lCzY64... to xBCcWw6gj... (flutter/engine#30284) * e28882a Roll Dart SDK from 01a9d4e9ede7 to a78eae43582d (1 revision) (flutter/engine#30288) * 368e3cc Revert Dart SDK to 2ace65b1b408 (flutter/engine#30290)

cbracken requested review from chunhtai and gspencergoog December 9, 2021 22:44

flutter-dashboard bot added the platform-windows label Dec 9, 2021

chunhtai reviewed Dec 9, 2021

View reviewed changes

chunhtai approved these changes Dec 9, 2021

View reviewed changes

cbracken merged commit df21689 into flutter:main Dec 9, 2021

cbracken deleted the a11y-focus-windows branch December 9, 2021 23:58

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 842281e4242b (8 revisions) flutter/flutter#95025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

f81b005

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 806d8bc03867 (9 revisions) flutter/flutter#95029

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

4202ecb

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5aa7b3006535 (12 revisions) flutter/flutter#95038

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

7b7d413

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5502a0ad57b7 (18 revisions) flutter/flutter#95042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

84a66dc

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 10, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

4e58bdb

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95062

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

f01af79

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 5ece42fee466 (21 revisions) flutter/flutter#95067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

6d1d7fe

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8d1272ba34d5 (22 revisions) flutter/flutter#95072

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

c4901bd

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to 8b074c8159a6 (23 revisions) flutter/flutter#95077

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

ebbcb3c

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95078

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

18276bc

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95081

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

4a03d9f

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to e1a71cf0daf8 (24 revisions) flutter/flutter#95086

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

8e92d40

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 11, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

af18dcd

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to ff7d4d6a0920 (26 revisions) flutter/flutter#95099

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

b63fbcd

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

b8731c7

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95106

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

b7a2f88

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 2f97ac4217b1 (27 revisions) flutter/flutter#95111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

2e96469

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 85f4d6861a5c (28 revisions) flutter/flutter#95112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

825b075

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

efc62c4

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

8937c35

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 5130b83da049 (29 revisions) flutter/flutter#95124

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

5875f57

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to e28882a1efdc (30 revisions) flutter/flutter#95128

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

849b37f

…#30256)

engine-flutter-autoroll mentioned this pull request Dec 12, 2021

Roll Engine from 79f750d4a541 to 368e3cc50592 (31 revisions) flutter/flutter#95132

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2021

df21689 Call IAccessible::accFocus to move a11y focus (flutter/engine…

19922e0

…#30256)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Call IAccessible::accFocus to move a11y focus #30256

Call IAccessible::accFocus to move a11y focus #30256

Uh oh!

cbracken commented Dec 9, 2021

Uh oh!

chunhtai Dec 9, 2021

Uh oh!

cbracken Dec 9, 2021

Uh oh!

chunhtai Dec 9, 2021

Uh oh!

cbracken Dec 9, 2021 •

edited

Loading

Uh oh!

chunhtai left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Call IAccessible::accFocus to move a11y focus #30256

Call IAccessible::accFocus to move a11y focus #30256

Uh oh!

Conversation

cbracken commented Dec 9, 2021

Pre-launch Checklist

Uh oh!

chunhtai Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

cbracken Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

chunhtai Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

cbracken Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cbracken Dec 9, 2021 •

edited

Loading