Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Dec 6, 2021

Reverts #30152

Reverting for g3 branch alignment.

@google-cla google-cla bot added the cla: yes label Dec 6, 2021
@zanderso zanderso requested a review from a-siva December 6, 2021 16:06
@zanderso zanderso merged commit 204aa6b into main Dec 6, 2021
@zanderso zanderso deleted the revert-30152-dart-sdk-flutter-engine-ea6f6e89-d170-4be5-aea9-02d5bd95c474-1638772034 branch December 6, 2021 17:21
@a-siva
Copy link
Contributor

a-siva commented Dec 6, 2021

I presume the reason for the review is the Dart SDK G3 roll hasn't happened yet. This morning in the VM team meeting folks were wondering if picking the engine version that has the Dart version 68bd330 as the version which will be branched by the engine.

Copy link
Contributor

@a-siva a-siva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see comment

@zanderso
Copy link
Member Author

zanderso commented Dec 6, 2021

Good point. I've requested an Engine -> Framework roll to the commit before the Dart roll that this PR reverts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants