Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Change Touch priority to YES #30041

Merged
arbreng merged 1 commit into from
Dec 2, 2021
Merged

[fuchsia] Change Touch priority to YES #30041

arbreng merged 1 commit into from
Dec 2, 2021

Conversation

@uysalere
Copy link
Contributor

@uysalere uysalere commented Dec 1, 2021 •
edited
Loading

This CL changes priority to YES so that the children can receive Touch events.

Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=89541

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
jaeheon
jaeheon approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@jaeheon jaeheon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken
Copy link
Member

cbracken commented Dec 1, 2021

This looks like it's hitting flutter/flutter#94492

@arbreng arbreng added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 1, 2021
@cbracken cbracken mentioned this pull request Dec 1, 2021
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Dec 1, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Android Debug Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 1, 2021
@arbreng arbreng merged commit 1a76ac2 into flutter:main Dec 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2021
@engine-flutter-autoroll
1a76ac2 [fuchsia] Change Touch response to YES (flutter/engine#30041)
f6abc7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 3, 2021
@engine-flutter-autoroll
1a76ac2 [fuchsia] Change Touch response to YES (flutter/engine#30041)
7cec3ce
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jaeheon jaeheon jaeheon approved these changes

@akbiggs akbiggs akbiggs approved these changes

@arbreng arbreng arbreng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-fuchsia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uysalere @cbracken @fluttergithubbot @jaeheon @akbiggs @arbreng