This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Add arg for old_gen_heap_size. #29875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
reviewed
Nov 22, 2021
arbreng
reviewed
Nov 22, 2021
arbreng
approved these changes
Nov 22, 2021
Contributor
arbreng
left a comment
arbreng
left a comment
There was a problem hiding this comment.
LGTM but highly recommend "args" instead of a custom key
akbiggs
force-pushed
the
old_gen_heap_size
branch
9 times, most recently
from
dd192c8 to
0cdd248
Compare
akbiggs
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
akbiggs
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
akbiggs
force-pushed
the
old_gen_heap_size
branch
from
0cdd248 to
c55f897
Compare
akbiggs
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: http://fxbug.dev/84893