-
Notifications
You must be signed in to change notification settings - Fork 6k
Windows: Add SystemSound support #29811
Windows: Add SystemSound support #29811
Conversation
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
dkwingsmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@dkwingsmt I was wondering the same thing. We do already use the I do think it's worth some thought how we might do this -- especially as I just spent a couple days on testing for similar code with regards to semantics to resolve flutter/flutter#101217. I think we can investigate that separately from this change though. |
|
Yeah I didn't realize it's implementing a feature that already exists in the Framework. |

This PR adds
SystemSound.playsupport.On win32, it calls
MessageBeep.On winuwp, it is not implemented because Windows App Cert Kit warns the usage of
MessageBeepand winrt seems not to have its equivalent API.I tried
ElementSoundPlayer, but it seems to work on xbox and can be called only on xaml's thread.This PR will fix flutter/flutter#62143.
No changes in
flutter/tests.Pre-launch Checklist
writing and running engine tests.
///).