Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

maybeGetInitialRouteFromIntent: check if URI data getPath() is null #29766

Merged
fluttergithubbot merged 1 commit into from
Dec 16, 2021
Merged

maybeGetInitialRouteFromIntent: check if URI data getPath() is null #29766

fluttergithubbot merged 1 commit into from
Dec 16, 2021

Conversation

@icota
Copy link
Contributor

@icota icota commented Nov 16, 2021

getPath returns a null in case of non-hierachical URIs like mailto

This PR avoids the app crashing with:

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.isEmpty()' on a null object reference

Fixes flutter/flutter#75261

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 16, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 16, 2021
@chinmaygarde
Copy link
Member

chinmaygarde commented Nov 18, 2021

Looks good to me but I don't know how to test this. cc @blasten for thoughts.

blasten
blasten suggested changes Nov 18, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test

@chinmaygarde
Copy link
Member

chinmaygarde commented Dec 2, 2021

cc @blasten. The test has been added per the suggestion. Please take another look.

blasten
blasten approved these changes Dec 3, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member

chinmaygarde commented Dec 9, 2021

The linter failure is real. @icota Can you patch that please so we can land this?

@icota
maybeGetInitialRouteFromIntent: check if URI data getPath() is null
8f9e9ed 
https://developer.android.com/reference/android/net/Uri?hl=da#getPath()
getPath returns a null in case of non-hierachical URIs like mailto

This avoids the app crashing with:
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.isEmpty()' on a null object reference
@icota
Copy link
Contributor Author

icota commented Dec 11, 2021

Thanks for letting me know @chinmaygarde. Fixed in 8f9e9ed

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 16, 2021
@fluttergithubbot fluttergithubbot merged commit 34a182e into flutter:main Dec 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2021
@engine-flutter-autoroll
34a182e maybeGetInitialRouteFromIntent: check if URI data getPath() i…
5ad2f57 
…s null (flutter/engine#29766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2021
@engine-flutter-autoroll
34a182e maybeGetInitialRouteFromIntent: check if URI data getPath() i…
beb8d90 
…s null (flutter/engine#29766)
@chunhtai chunhtai mentioned this pull request May 9, 2023
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@thecalamiity thecalamiity thecalamiity left review comments

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to deep link into Android app

5 participants

@icota @chinmaygarde @blasten @thecalamiity @fluttergithubbot