Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Cherrypick of PR flutter/engine/pull/29531 #29725

Merged
godofredoc merged 1 commit into from
Nov 13, 2021
Merged

Cherrypick of PR flutter/engine/pull/29531 #29725

godofredoc merged 1 commit into from
Nov 13, 2021

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Nov 13, 2021

Cherry pick:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 13, 2021

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla google-cla bot added the cla: yes label Nov 13, 2021
@godofredoc godofredoc merged commit f21711c into flutter:flutter-2.8-candidate.2 Nov 13, 2021
@godofredoc godofredoc deleted the flutter-2.8-candidate.2 branch December 1, 2021 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@devoncarew devoncarew Awaiting requested review from devoncarew

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso