Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Set system bar appearance using WindowInsetsController" #29403

Merged
fluttergithubbot merged 2 commits into from
Oct 29, 2021
Merged

Reland "Set system bar appearance using WindowInsetsController" #29403

fluttergithubbot merged 2 commits into from
Oct 29, 2021

Conversation

@blasten
Copy link

@blasten blasten commented Oct 29, 2021

Relands #29060

This PR requires to update the Bazel rules in g3 (@renyu FYI)

Revert "Revert "Set system bar appearance using WindowInsetsControlle…
be7a40d 
…rCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter#29206)"

This reverts commit b1e7ad8.
@blasten blasten requested a review from GaryQian October 29, 2021 06:45
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
GaryQian
GaryQian approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2021
@fluttergithubbot fluttergithubbot merged commit 64ca2c2 into flutter:master Oct 29, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
48641db 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
1bac654 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
a17ce13 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
cb65e75 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
f8b3d3a 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
d9dc21b 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
0ebb563 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
5a0d047 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
9bba226 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
893b015 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
31fcce3 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
545980a 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
24515a5 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
155101c 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
97a90cd 
…r" (flutter/engine#29403)
@renyou
Copy link
Contributor

renyou commented Oct 31, 2021

@blasten Hi, I understand the breakage is expected. But from the process point of view, we would prefer to have the fix in Google before landing the PR. So the build failures don't block the testing of the PRs merged after this.

Let's discuss the details in b/204613523.

FYI @xster @zanderso

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
f9d42a4 
…r" (flutter/engine#29403)
blasten pushed a commit that referenced this pull request Oct 31, 2021
Revert "Reland "Set system bar appearance using WindowInsetsControlle…
1e54d89 
…r" (#29403)"

This reverts commit 64ca2c2.
@blasten blasten mentioned this pull request Oct 31, 2021
Closed
@blasten
Copy link
Author

blasten commented Oct 31, 2021

@renyou Makes sense. this is being fixed in http://cl/406716902

@blasten blasten deleted the reland_system_ui branch October 31, 2021 23:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
bd753de 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
264f900 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
06a21ed 
…r" (flutter/engine#29403)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021
@engine-flutter-autoroll
64ca2c2 Reland "Set system bar appearance using WindowInsetsControlle…
a41b927 
…r" (flutter/engine#29403)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @renyou @GaryQian @fluttergithubbot