[fuchsia] INTERNAL epitaph for non-zero return codes #29330

akbiggs · 2021-10-26T07:05:29Z

As discussed in #29142, we write an INTERNAL epitaph when killing a component that had a non-zero return code ("error"), and OK when killing a component that had a zero return code ("success").

Bug: fxb/50694

@gebressler

flutter-dashboard · 2021-10-26T07:05:31Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gebressler · 2021-10-26T17:41:23Z

LGTM

…

On Tue, Oct 26, 2021 at 12:05 AM Alexander Biggs ***@***.***> wrote: As discussed in #29142 <#29142>, we write an INTERNAL epitaph when killing a component that had a non-zero return code ("error"), and OK when killing a component that had a zero return code ("success"). @gebressler <https://github.com/gebressler> ------------------------------ You can view, comment on, or merge this pull request online at: #29330 Commit Summary - [fuchsia] INTERNAL epitaph for non-zeroo return codes <bed427f> File Changes (2 files <https://github.com/flutter/engine/pull/29330/files>) - *M* shell/platform/fuchsia/dart_runner/dart_component_controller_v2.cc <https://github.com/flutter/engine/pull/29330/files#diff-3b30823fe43b689d2cec125bb13ec2993a09c195401f3052231249068f0f7d13> (22) - *M* shell/platform/fuchsia/flutter/component_v2.cc <https://github.com/flutter/engine/pull/29330/files#diff-db07ee16fa302683ead19d2565e43be31712591ed828c6ae82d0294565f246c6> (32) Patch Links: - https://github.com/flutter/engine/pull/29330.patch - https://github.com/flutter/engine/pull/29330.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29330>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQB2JV6LYZV2HUJGZ53DXOLUIZHMLANCNFSM5GXAWG5A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

…/engine#29330)

[fuchsia] INTERNAL epitaph for non-zeroo return codes

bed427f

akbiggs requested a review from chaselatta October 26, 2021 07:05

flutter-dashboard bot added platform-fuchsia needs tests labels Oct 26, 2021

google-cla bot added the cla: yes label Oct 26, 2021

akbiggs requested review from arbreng and chandarrengoog October 28, 2021 22:37

arbreng approved these changes Oct 30, 2021

View reviewed changes

akbiggs merged commit c96c7ff into flutter:master Oct 30, 2021

akbiggs deleted the internal-error branch October 30, 2021 00:54

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to c96c7ffb9773 (21 revisions) flutter/flutter#92742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

d0d7985

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 8e73d90452eb (22 revisions) flutter/flutter#92743

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

df6a58c

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 8e73d90452eb (22 revisions) flutter/flutter#92748

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

7cdcc84

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 8e73d90452eb (22 revisions) flutter/flutter#92751

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

8261065

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to ed3e6d2b7350 (23 revisions) flutter/flutter#92763

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

1fe487e

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 47446ca043c2 (24 revisions) flutter/flutter#92765

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

837333f

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 47446ca043c2 (24 revisions) flutter/flutter#92771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

c8a48c3

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 30, 2021

Roll Engine from 3a0a63c2d209 to 5597ef01f5d2 (25 revisions) flutter/flutter#92772

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

cd8d5f1

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to 5597ef01f5d2 (25 revisions) flutter/flutter#92775

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

1eebe57

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to 5597ef01f5d2 (25 revisions) flutter/flutter#92778

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

2db94de

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to 8ae70a59792e (26 revisions) flutter/flutter#92781

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

8e60107

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to e781ed8b2980 (27 revisions) flutter/flutter#92784

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

c666458

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to e781ed8b2980 (27 revisions) flutter/flutter#92786

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

5daffb9

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Oct 31, 2021

Roll Engine from 3a0a63c2d209 to e781ed8b2980 (27 revisions) flutter/flutter#92794

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

fa3750a

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Nov 1, 2021

Roll Engine from 3a0a63c2d209 to 9f3ca93d8d59 (28 revisions) flutter/flutter#92813

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

dc4ef31

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Nov 1, 2021

Roll Engine from 3a0a63c2d209 to 1eec8c1e57e4 (29 revisions) flutter/flutter#92819

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

d8127a8

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Nov 1, 2021

Roll Engine from 3a0a63c2d209 to 9c5f5d23347e (30 revisions) flutter/flutter#92823

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

472c631

…/engine#29330)

engine-flutter-autoroll mentioned this pull request Nov 1, 2021

Roll Engine from 3a0a63c2d209 to 9c88e86f5d05 (31 revisions) flutter/flutter#92828

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 1, 2021

c96c7ff [fuchsia] INTERNAL epitaph for non-zero return codes (flutter…

ebefc3a

…/engine#29330)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fuchsia] INTERNAL epitaph for non-zero return codes #29330

[fuchsia] INTERNAL epitaph for non-zero return codes #29330

Uh oh!

akbiggs commented Oct 26, 2021 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 26, 2021

Uh oh!

gebressler commented Oct 26, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[fuchsia] INTERNAL epitaph for non-zero return codes #29330

[fuchsia] INTERNAL epitaph for non-zero return codes #29330

Uh oh!

Conversation

akbiggs commented Oct 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Oct 26, 2021

Uh oh!

gebressler commented Oct 26, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akbiggs commented Oct 26, 2021 •

edited

Loading