This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Windows: Add SettingsPlugin to add theme change support in win32 #29303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moko256
force-pushed
the
moko256_windows_settings_plugin
branch
from
d9a094d to
57a8f24
Compare
fluttergithubbot
force-pushed
the
master
branch
from
b1a8771 to
2962099
Compare
8 tasks
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
moko256
force-pushed
the
moko256_windows_settings_plugin
branch
from
57a8f24 to
4dbd568
Compare
Contributor
Author
|
I resolved the conflicts and this is ready for review. |
moko256
force-pushed
the
moko256_windows_settings_plugin
branch
2 times, most recently
from
b2853ca to
e9d5973
Compare
moko256
force-pushed
the
moko256_windows_settings_plugin
branch
from
e9d5973 to
42b8e2a
Compare
cbracken
approved these changes
Apr 28, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Overall, this looks great. Thank you for the patch.
loic-sharma
reviewed
Apr 28, 2022
moko256
force-pushed
the
moko256_windows_settings_plugin
branch
from
42b8e2a to
c5d1d01
Compare
dkwingsmt
approved these changes
Apr 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
SettingsPluginto add theme change support in win32.In the #28131 and flutter/flutter#88520, the top-level window message is used to notify brightness change, but I found I cannot use with the same pattern to notify text scale factor change.
In this PR, I separate sending flutter/settings as
SettingsPlugin, remove the functions to notify brightness change from out of engine, and add watching brightness change inSettingsPluginwith registry when win32.This PR will remove some public functions added in #28131, but that is only used in flutter/flutter#88520 that is not merged, so I think it does not cause large effect.
This PR will close flutter/flutter#88520.
This PR will close flutter/flutter#98355.
No changes in
flutter/tests.Pre-launch Checklist
writing and running engine tests.
///).