-
Notifications
You must be signed in to change notification settings - Fork 6k
Use the SkParagraph text renderer by default #28912
Use the SkParagraph text renderer by default #28912
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Waiting for the DL patch to stick its landing. |
|
This is going to slip by a couple of weeks. Adding the WIP tag. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
b1a8771 to
2962099
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
f0e327f to
95c574f
Compare
95c574f to
c9b49ef
Compare
b5162c9 Use the SkParagraph text renderer by default (flutter/engine#28912)
b5162c9 Use the SkParagraph text renderer by default (flutter/engine#28912)
|
This broke tests in flutter/tests, which per our breaking change policy requires a migration guide. Can you link to that guide from this PR for future archeologists? thanks! Also I can't help but notice that this PR violated our tests policy. PRs without tests must have an explicit test exemption as per the comment from the bot above; this PR does not have such an exemption. Please make sure to follow the processes. Thanks. |
b5162c9 Use the SkParagraph text renderer by default (flutter/engine#28912)
No description provided.