Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chinmaygarde
Copy link
Member

Waiting for the DL patch to stick its landing.

@chinmaygarde
Copy link
Member

This is going to slip by a couple of weeks. Adding the WIP tag.

@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Oct 14, 2021
@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:16
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@godofredoc godofredoc changed the base branch from master to main November 24, 2021 07:19
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@jason-simmons jason-simmons added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jan 24, 2022
@fluttergithubbot fluttergithubbot merged commit b5162c9 into flutter:main Jan 24, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2022
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Jan 25, 2022
b5162c9 Use the SkParagraph text renderer by default (flutter/engine#28912)
jason-simmons added a commit to flutter/flutter that referenced this pull request Jan 25, 2022
b5162c9 Use the SkParagraph text renderer by default (flutter/engine#28912)
@Hixie
Copy link
Contributor

Hixie commented Jan 25, 2022

This broke tests in flutter/tests, which per our breaking change policy requires a migration guide. Can you link to that guide from this PR for future archeologists? thanks!

Also I can't help but notice that this PR violated our tests policy. PRs without tests must have an explicit test exemption as per the comment from the bot above; this PR does not have such an exemption. Please make sure to follow the processes. Thanks.

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes needs tests platform-android platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants