This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate unnecessary canvaskit imports #28787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
GaryQian
approved these changes
Sep 21, 2021
Fixes the following lints: ``` Analyzing web_ui... info - lib/src/engine/canvaskit/surface_factory.dart:8:8 - The import of '../util.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import info - lib/src/engine/canvaskit/surface_factory.dart:9:8 - The import of 'embedded_views.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import info - lib/src/engine/canvaskit/surface_factory.dart:10:8 - The import of 'surface.dart' is unnecessary as all of the used elements are also provided by the import of '../../engine.dart'. Try removing the import directive. - unnecessary_import ```
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 22, 2021
GaryQian
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 22, 2021
* ffdaa4b Implement a default font manager for Fuchsia. (flutter/engine#28673) * 0608a01 Replace jcenter() for mavenCentral() (flutter/engine#28777) * ccec08a Roll Dart SDK from a0243abd09e3 to 86a21d182523 (6 revisions) (flutter/engine#28779) * e2bd498 [web] clear surfaces on hot restart (flutter/engine#28675) * 6eceff5 Roll Skia from e32309d771ee to a48e7b0186b3 (10 revisions) (flutter/engine#28782) * 3c01c60 Eliminate unnecessary canvaskit imports (flutter/engine#28787) * 4e4873e Set MinimumOSVersion to iOS 9 in Info.plist (flutter/engine#28783) * 4872f8f Roll Dart SDK from 86a21d182523 to c2429dee845e (1 revision) (flutter/engine#28789) * d8120eb Roll Skia from a48e7b0186b3 to bb30fc16e1be (1 revision) (flutter/engine#28791) * 13a631a Roll Fuchsia Mac SDK from 3k3-vCrm5... to NM9FaaYay... (flutter/engine#28792) * a60c0c3 Roll Fuchsia Linux SDK from JD40LpEJO... to bWZcp2jnx... (flutter/engine#28793) * 04d47cd Roll Skia from bb30fc16e1be to 5527735121f5 (1 revision) (flutter/engine#28794) * 827c62a Roll Dart SDK from c2429dee845e to 715a98df1828 (1 revision) (flutter/engine#28795) * f16f0ce Roll Skia from 5527735121f5 to cb25d566c21d (3 revisions) (flutter/engine#28796) * ec009a3 Roll Dart SDK from 715a98df1828 to 4e396689de4f (1 revision) (flutter/engine#28797) * df5b566 Disable failing unit tests on UWP (flutter/engine#28785) * b6e7440 Roll Dart SDK from 4e396689de4f to 6e17953f4e7e (1 revision) (flutter/engine#28800) * fa2eb22 [canvaskit] Fix bug when overlays are disabled (flutter/engine#28790)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
* ffdaa4b Implement a default font manager for Fuchsia. (flutter/engine#28673) * 0608a01 Replace jcenter() for mavenCentral() (flutter/engine#28777) * ccec08a Roll Dart SDK from a0243abd09e3 to 86a21d182523 (6 revisions) (flutter/engine#28779) * e2bd498 [web] clear surfaces on hot restart (flutter/engine#28675) * 6eceff5 Roll Skia from e32309d771ee to a48e7b0186b3 (10 revisions) (flutter/engine#28782) * 3c01c60 Eliminate unnecessary canvaskit imports (flutter/engine#28787) * 4e4873e Set MinimumOSVersion to iOS 9 in Info.plist (flutter/engine#28783) * 4872f8f Roll Dart SDK from 86a21d182523 to c2429dee845e (1 revision) (flutter/engine#28789) * d8120eb Roll Skia from a48e7b0186b3 to bb30fc16e1be (1 revision) (flutter/engine#28791) * 13a631a Roll Fuchsia Mac SDK from 3k3-vCrm5... to NM9FaaYay... (flutter/engine#28792) * a60c0c3 Roll Fuchsia Linux SDK from JD40LpEJO... to bWZcp2jnx... (flutter/engine#28793) * 04d47cd Roll Skia from bb30fc16e1be to 5527735121f5 (1 revision) (flutter/engine#28794) * 827c62a Roll Dart SDK from c2429dee845e to 715a98df1828 (1 revision) (flutter/engine#28795) * f16f0ce Roll Skia from 5527735121f5 to cb25d566c21d (3 revisions) (flutter/engine#28796) * ec009a3 Roll Dart SDK from 715a98df1828 to 4e396689de4f (1 revision) (flutter/engine#28797) * df5b566 Disable failing unit tests on UWP (flutter/engine#28785) * b6e7440 Roll Dart SDK from 4e396689de4f to 6e17953f4e7e (1 revision) (flutter/engine#28800) * fa2eb22 [canvaskit] Fix bug when overlays are disabled (flutter/engine#28790)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following lints triggered by #28675:
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.