Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Re-land] Add SPIR-V FragmentShader API to painting.dart #28208

Merged
clocksmith merged 131 commits into from
Aug 20, 2021
Merged

[Re-land] Add SPIR-V FragmentShader API to painting.dart #28208

clocksmith merged 131 commits into from
Aug 20, 2021

Conversation

@clocksmith
Copy link
Contributor

@clocksmith clocksmith commented Aug 19, 2021 •
edited
Loading

Co-authored-by Christopher Crawford [email protected]

Re-land #26996

closes flutter/flutter#85237
closes flutter/flutter#85239

  • Add a SPIR-V FragmentShader interface in painting.dart
  • Create end to end pixel tests for ops supported by the SPIR-V to SkSL transpiler
  • The end to end test also tests the c++ fragment shader implementation

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

clocksmith added 30 commits July 28, 2021 20:01
@clocksmith @chriscraws
Add FragmentShader dart API
18573ad
@clocksmith @chriscraws
Add fragment_shader.h and fragment_shader.cc
0bac429
@clocksmith @chriscraws
Add and fix fragment_shader_test.dart
735bb08
@clocksmith @chriscraws
test
ebd002e
@clocksmith @chriscraws
typos
652c316
@clocksmith @chriscraws
Add some more ops tests
997baa9
@clocksmith @chriscraws
testing shaderc
1140840
@clocksmith @chriscraws
add configurations so that engine can build with FragmentShader
8009ac0
@clocksmith @chriscraws
Uncomment glsl_to_spirv build rules
49466d6
@clocksmith @chriscraws
Add more op sources and iterate on glsl_to_spirv
9e49583
@clocksmith @chriscraws
revert DEPS
63459ea
@clocksmith @chriscraws
revert DEPS
005273d
@clocksmith @chriscraws
revert DEPS
b8cc199
@clocksmith @chriscraws
revert DEPS
7f9394a
@clocksmith @chriscraws
Update existing e2e tests
e05634f
@clocksmith @chriscraws
add shaderc opts
22dcac3
@clocksmith @chriscraws
Add simple test
43b871e
@clocksmith @chriscraws
iterate on pixel test infra
8c606b0
@clocksmith @chriscraws
Update tests
59c4790
@clocksmith @chriscraws
update build rules
0c525bd
@clocksmith @chriscraws
Clean up tests, add glsl tests, add opTypeInt
f174190
@clocksmith @chriscraws
uncomment tests and adjust README
4a46174
@clocksmith @chriscraws
Remove benchmarks from this branch, can be added sep
a4908e7
@clocksmith @chriscraws
formatting
02875af
@clocksmith @chriscraws
formatting
dca3c5e
@clocksmith @chriscraws
fix typo
99a704a
@clocksmith @chriscraws
formatting
3ab467e
@clocksmith @chriscraws
formatting
5572332
@clocksmith @chriscraws
formatting
2675bb5
@clocksmith @chriscraws
formatting
94667fb
@flutter-dashboard flutter-dashboard bot added platform-fuchsia platform-web Code specifically for the web engine labels Aug 19, 2021
@clocksmith clocksmith requested a review from zanderso August 19, 2021 21:38
@google-cla
Copy link

google-cla bot commented Aug 19, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 19, 2021
@clocksmith clocksmith changed the title [Re-land]Add SPIR-V FragmentShader API to painting.dart [Re-land] Add SPIR-V FragmentShader API to painting.dart Aug 19, 2021
@clocksmith
Copy link
Contributor Author

clocksmith commented Aug 19, 2021

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Aug 19, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@chriscraws
Copy link
Contributor

chriscraws commented Aug 19, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 19, 2021
@clocksmith clocksmith merged commit a80fb1b into flutter:master Aug 20, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 20, 2021
@engine-flutter-autoroll
a80fb1b [Re-land] Add SPIR-V FragmentShader API to painting.dart (flu…
fce4b54 
…tter/engine#28208)
zanderso added a commit that referenced this pull request Aug 21, 2021
@zanderso
Revert "[Re-land] Add SPIR-V FragmentShader API to painting.dart (#28208
998df46 
)"

This reverts commit a80fb1b.
@zanderso zanderso mentioned this pull request Aug 21, 2021
Closed
chriscraws added a commit to chriscraws/engine that referenced this pull request Aug 23, 2021
@clocksmith @chriscraws
[Re-land] Add SPIR-V FragmentShader API to painting.dart (flutter#28208)
e1fb8db 
[Re-land] Add SPIR-V FragmentShader API to painting.dart

- Add a SPIR-V FragmentShader interface in painting.dart
- Create end to end pixel tests for ops supported by the SPIR-V to SkSL transpiler
- The end to end tests also test the c++ fragment shader implementation

Co-authored-by: Christopher Crawford <[email protected]>
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@clocksmith @chriscraws @filmil
[Re-land] Add SPIR-V FragmentShader API to painting.dart (flutter#28208)
05267ee 
[Re-land] Add SPIR-V FragmentShader API to painting.dart

- Add a SPIR-V FragmentShader interface in painting.dart
- Create end to end pixel tests for ops supported by the SPIR-V to SkSL transpiler
- The end to end tests also test the c++ fragment shader implementation

Co-authored-by: Christopher Crawford <[email protected]>
@goderbauer goderbauer mentioned this pull request Jul 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-fuchsia platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add missing ops to Spirv transpiler Expose a FragmentShader API in painting.dart with c++ support

3 participants

@clocksmith @chriscraws @zanderso