This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use a Pbuffer surface when the onscreen surface is not available for snapshotting on Android" #27607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blasten
approved these changes
Jul 20, 2021
Contributor
Author
|
Haha sorry @jimsimon |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
…t available for snapshotting on Android (flutter#27141)" (flutter/engine#27607)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
…t available for snapshotting on Android (flutter#27141)" (flutter/engine#27607)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
…t available for snapshotting on Android (flutter#27141)" (flutter/engine#27607)
This was referenced Jul 21, 2021
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Jul 21, 2021
…ble for snapshotting on Android (flutter#27141)" (flutter#27607)" This reverts commit 0c121d3.
dnfield
added a commit
that referenced
this pull request
Jul 21, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…ble for snapshotting on Android (flutter#27141)" (flutter#27607) This reverts commit a1180b1.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
* Reland "Use a Pbuffer surface when the onscreen surface is not available for snapshotting on Android (flutter#27141)" (flutter#27607)" This reverts commit 0c121d3. * Do not let gradle download SDK deps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27141
Test is having issues sometimes with the Android SDK - I'll try to update that and then reland this.
Failure at https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Unopt/787/overview
@jimsimon @blasten