This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid passive clipboard read on Android #27215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wytesk133
force-pushed
the
master
branch
6 times, most recently
from
f1f2945 to
4bf4fd5
Compare
blasten
reviewed
Jul 8, 2021
shell/platform/android/test/io/flutter/plugin/platform/PlatformPluginTest.java
Outdated
Show resolved
Hide resolved
blasten
reviewed
Jul 8, 2021
Android 12 introduces a toast message that appears when an app reads the content on the clipboard. Currently, whenever there is a `TextField` widget, the app reads from the clipboard passively to determine whether the clipboard is empty and whether the "Paste" button should be shown. To avoid unintended access, both the Flutter engine and the Flutter framework need to be updated to use the appropriate API to check whether the clipboard is empty. Slightly breaking change: Previously, if the clipboard contains an empty string, `clipboardHasStrings` returns `false`, but Without actually accessing clipboard data (preferred behavior), it is not possible to distinguish between empty and non-empty string contents.
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 12 introduces a toast message that appears when an app reads the content on the clipboard. Currently, whenever there is a
TextFieldwidget, the app reads from the clipboard passively to determine whether the clipboard is empty and whether the "Paste" button should be shown. To avoid unintended access, both the Flutter engine and the Flutter framework need to be updated to use the appropriate API to check whether the clipboard is empty.Slightly breaking change: Previously, if the clipboard contains an empty string,
clipboardHasStringsreturnsfalse, but Without actually accessing clipboard data (preferred behavior), it is not possible to distinguish between empty and non-empty string contents.This is a pre-requisite for fixing b/192897521 and flutter/flutter#74139
The remaining steps are:
hasStrings()influtter/lib/src/services/clipboard.dartandflutter/lib/src/widgets/text_selection.dartto callhasStrings().Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.