This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add SPIR-V FragmentShader API to painting.dart #26996
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is mostly ready, leaving WIP tag on, but would like to collect feedback and comments (specifically on testing strategy and API) @chinmaygarde @zanderso |
zanderso
reviewed
Jul 27, 2021
Member
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to FlutterActivityDelegate.java, _embedder.yaml, and clang_tidy_test.dart in this PR appear to be the result of a bad merge/rebase, and I suspect are what is confusing the CLA bot.
zanderso
reviewed
Jul 27, 2021
Contributor
|
@googlebot I consent. |
Contributor
Author
|
License issues fixed but tree is now broken 💔 |
zanderso
approved these changes
Aug 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2021
zanderso
added a commit
that referenced
this pull request
Aug 19, 2021
9 tasks
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Aug 23, 2021
…" (flutter#28202) This reverts commit 6d6ce34.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Add SPIR-V FragmentShader API to painting.dart
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
…" (flutter#28202) This reverts commit 6d6ce34.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by Christopher Crawford [email protected]
closes flutter/flutter#85237
partially addresses flutter/flutter#85239
painting.dartPre-launch Checklist
writing and running engine tests.
///).