This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] make analysis options delta of root options #26991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
Import the root options and explicitly disable lints that our code violates. Fix several lint violations.
yjbanov
force-pushed
the
sync-analysis-options-1
branch
from
1f9a940 to
6aaa009
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2021
* ce489a5 Roll Skia from 0f1ac21185fe to b1590f15a32b (1 revision) (flutter/engine#27000) * 92e24d8 Record raster end as soon as frame is submitted (flutter/engine#26970) * 1f35cce Remove presubmit flake reporting instructions from issue template. (flutter/engine#26997) * f5bc55e Roll Skia from b1590f15a32b to eef5b0e933e3 (2 revisions) (flutter/engine#27001) * 8f57dfe Roll Fuchsia Mac SDK from z6trYeCMx... to R1ENSI-od... (flutter/engine#27002) * 360d2d8 Surface frame number identifier through window (flutter/engine#26785) * ed87f7c Roll Dart SDK from d2025958e351 to eca780278d49 (1 revision) (flutter/engine#27003) * f558e2a Roll Fuchsia Linux SDK from TqViQQzJo... to 4udsaggtH... (flutter/engine#27006) * 8ae3ff7 Fix Fuchsia build on Mac (flutter/engine#27007) * b259ea6 Revert "[Engine] Support for Android Fullscreen Modes (#25785)" (flutter/engine#27014) * 6e105c9 Roll Skia from eef5b0e933e3 to e5766b808045 (12 revisions) (flutter/engine#27011) * cfea27e Allow fuchsia_archive to accept a cml file and cmx file (flutter/engine#27012) * 9ef94a2 [web] Librarify paragraph/text files (flutter/engine#26888) * cc2c361 Roll Dart SDK from eca780278d49 to bbd701b4ba76 (1 revision) (flutter/engine#27015) * f6fcab4 Roll CanvasKit to 0.28.1 (flutter/engine#27013) * db8ed9e38 Configure contexts to reduce shader variations. (flutter/engine#27016) * 94876ed Roll Skia from e5766b808045 to 661abd0f8d64 (7 revisions) (flutter/engine#27020) * 35e297d Update ci.yaml documentation link (flutter/engine#26922) * 6a87e0b [web] fix actions flags in SemanticsTester (flutter/engine#26992) * 53ac32f Re-land Android fullscreen support (flutter/engine#27018) * 1417a82 [web] make analysis options delta of root options (flutter/engine#26991) * b84ebe5 Roll Skia from 661abd0f8d64 to 1bddd42b9897 (3 revisions) (flutter/engine#27023) * 4f3d88e [web] Librarify keyboard files (flutter/engine#26917) * 9d09594 Roll Dart SDK from bbd701b4ba76 to fff3a3747a18 (1 revision) (flutter/engine#27024)
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
Import the root options and explicitly disable lints that our code violates. Fix several lint violations.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Import the root options and explicitly disable lints that our code violates. Fix several lint violations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root analysis options has been updated over time. However, because the web version effectively ignores it (despite trying to list all lints that don't work yet) we haven't picked up any of the new lints, because the analyzer wasn't making the author aware of the violations in the web code. This PR changes the approach: